fix(player): cover the navigation bar area in fullscreen so the feed doesn't show behind the player#56
Open
Priveetee wants to merge 1 commit into
Conversation
…doesn't show behind the player
Contributor
Author
|
Hope that now it won't be some other repercussion in other places 😭😭😭 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context (bug report):
Follow-up to the edge-to-edge work in #53.
Summary
In fullscreen the player did not cover the navigation-bar area, so a strip at the bottom showed the feed behind it (Shorts, landscape and Bilibili vertical videos). This makes the player bottom-sheet inset handling fullscreen-aware: the player covers the whole screen in fullscreen, while the collapsed mini player still stays above the nav bar.
Problem
The player bottom sheet used Material's
paddingBottomSystemWindowInsets, which shrinks the sheet content by the system-bar insets and is not fullscreen-aware. In fullscreen the content stopped above the nav bar:Changes
activity_main.xml: dropapp:paddingBottomSystemWindowInsetson the player holder.VideoDetailFragment: apply the status/navigation-bar insets manually and fullscreen-aware (holder padding + bottom-sheet peek): zero in fullscreen so the player fills the screen, the nav-bar inset otherwise so the mini player / detail stay above the bars.Validation
Pixel 8 emulator (API 36), 3-button navigation: in fullscreen the player now covers the whole screen (no feed strip at the bottom); the collapsed mini player still sits above the nav bar.