feat: 🎉 Add configurable CRD health checks#675
Open
titigmr wants to merge 1 commit into
Open
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Motivation
The health check logic in
HelmReleaseHealthResolverwork for a fixed set of resources:Deployment,StatefulSet,DaemonSet, andCNPG Cluster.The CNPG case shows that supporting CRDs is needed but the current implementation requires a code change for each new CRD. Making the approach generic is more valuable than continuing to add hardcoded CRD cases.
What changed
In addition to the default behavior,
HelmReleaseHealthResolverreads a list of CRD health check configurations fromhealth.custom-crd.checkswith two strategies:FIELDS: reads two integer fields from status (e.g. instances / readyInstances). Used by CNPG.CONDITION: checksstatus.conditionsfor a condition of the configured type with status:True(generally default behavior for CRD).CNPG, previously hardcoded, is now declared as the default entry in
application.properties. Existing behaviour is preserved without any configuration change.Usage example - Crossplane OpenStack InstanceV2