Convert .pxi include files to .pxd/.pyx in dpnp/tensor#2913
Open
vlad-perevezentsev wants to merge 14 commits into
Open
Convert .pxi include files to .pxd/.pyx in dpnp/tensor#2913vlad-perevezentsev wants to merge 14 commits into
vlad-perevezentsev wants to merge 14 commits into
Conversation
vlad-perevezentsev
requested review from
antonwolfy and
ndgrigorian
as code owners
Collaborator
|
coverage: 78.154% (-0.09%) from 78.242% — update_tensor_cython_pxi into master |
Contributor
|
Array API standard conformance tests for dpnp=0.21.0dev0=py313h509198e_62 ran successfully. |
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/pull/2913/index.html |
antonwolfy
reviewed
May 13, 2026
| from cpython.buffer cimport PyObject_CheckBuffer | ||
| from numpy import ndarray | ||
|
|
||
| from ._usmarray cimport usm_ndarray |
Contributor
There was a problem hiding this comment.
Does not that produce a circular dependency? (_usmarray ↔ _slicing)
Contributor
Author
There was a problem hiding this comment.
_slicing.pxd itself does not depend on _usmarray;
It is only needed for isinstance() checks in .pyx implementation so this circular cimport is safe
ndgrigorian
reviewed
May 15, 2026
ndgrigorian
reviewed
May 15, 2026
ndgrigorian
reviewed
May 15, 2026
ndgrigorian
reviewed
May 27, 2026
Comment on lines
+35
to
+51
| cdef int UAR_BOOL = UAR_BOOL_VALUE | ||
| cdef int UAR_BYTE = UAR_BYTE_VALUE | ||
| cdef int UAR_UBYTE = UAR_UBYTE_VALUE | ||
| cdef int UAR_SHORT = UAR_SHORT_VALUE | ||
| cdef int UAR_USHORT = UAR_USHORT_VALUE | ||
| cdef int UAR_INT = UAR_INT_VALUE | ||
| cdef int UAR_UINT = UAR_UINT_VALUE | ||
| cdef int UAR_LONG = UAR_LONG_VALUE | ||
| cdef int UAR_ULONG = UAR_ULONG_VALUE | ||
| cdef int UAR_LONGLONG = UAR_LONGLONG_VALUE | ||
| cdef int UAR_ULONGLONG = UAR_ULONGLONG_VALUE | ||
| cdef int UAR_FLOAT = UAR_FLOAT_VALUE | ||
| cdef int UAR_DOUBLE = UAR_DOUBLE_VALUE | ||
| cdef int UAR_CFLOAT = UAR_CFLOAT_VALUE | ||
| cdef int UAR_CDOUBLE = UAR_CDOUBLE_VALUE | ||
| cdef int UAR_TYPE_SENTINEL = UAR_TYPE_SENTINEL_VALUE | ||
| cdef int UAR_HALF = UAR_HALF_VALUE |
Collaborator
There was a problem hiding this comment.
seems redundant to cdef them here and in usmarray.pyx, is there a way to do it in something common?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes to replace Cython textual includes with proper module imports in
dpnp/tensor.pxi files are converted into corresponding .pxd and .pyx modules for _slicing.pxi, _stride_utils.pxi and _types.pxi`
This change replaces the include
.pxipattern with standard Cython cimport statements and improving modularity