Skip to content

Read signing golden fixtures from spec checkout#64

Merged
negillett merged 2 commits into
mainfrom
phase3-sdk-signing-golden
May 30, 2026
Merged

Read signing golden fixtures from spec checkout#64
negillett merged 2 commits into
mainfrom
phase3-sdk-signing-golden

Conversation

@negillett

Copy link
Copy Markdown
Member

Summary

  • Prefer INTENTPROOF_SPEC_DIR/golden/sdk-signing in signing golden tests.
  • Checkout spec in CI; add fixture sync gate.

Phase 3 drift D.9. Requires spec #100 on main for CI green.

Test plan

  • python3 -m pytest
  • bash scripts/run-coverage-gate.sh

@cursor

cursor Bot commented May 30, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Changes how signing conformance is validated in CI and ties releases to an external spec repo/branch fallback, but does not alter runtime signing logic in the SDK.

Overview
Signing golden tests now read fixtures from INTENTPROOF_SPEC_DIR/golden/sdk-signing when that env var is set, and otherwise keep using tests/fixtures for local runs.

CI checks out IntentProof/intentproof-spec, falls back to phase3-ecosystem-conformance if golden/sdk-signing is missing on main, runs coverage with INTENTPROOF_SPEC_DIR, and adds a sync gate that fails when mirrored signing_* files under tests/fixtures differ from the spec golden copies.

Reviewed by Cursor Bugbot for commit bf59b99. Bugbot is set up for automated code reviews on this repo. Configure here.

Signed-off-by: Nathan Gillett <nathan@intentproof.io>
@negillett negillett force-pushed the phase3-sdk-signing-golden branch from c331183 to 26ef905 Compare May 30, 2026 18:56
Signed-off-by: Nathan Gillett <nathan@intentproof.io>
@negillett negillett merged commit f29f2b0 into main May 30, 2026
10 checks passed
@negillett negillett deleted the phase3-sdk-signing-golden branch May 30, 2026 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant