Skip to content

Update WeatherTable.json#2801

Open
Daneel53 wants to merge 1 commit into
Interkarma:masterfrom
Daneel53:Fix-WeatherTable.cs
Open

Update WeatherTable.json#2801
Daneel53 wants to merge 1 commit into
Interkarma:masterfrom
Daneel53:Fix-WeatherTable.cs

Conversation

@Daneel53

@Daneel53 Daneel53 commented Jun 14, 2026

Copy link
Copy Markdown
Collaborator

Total values for Woodlands/Winter was only 90 and not 100 as per all other places/seasons.

Total values for Woodlands/Winter was only 90 and not 100.
@Daneel53

Daneel53 commented Jun 14, 2026

Copy link
Copy Markdown
Collaborator Author

Tested in game, the following warning when loading the save in Daggerfall City disappear.
Unity_2026-06-13_18-55-48

@petchema

Copy link
Copy Markdown
Collaborator

Bug originates from the Daggerfall Chronicles, where those tables came from https://en.uesp.net/wiki/Daggerfall:Climate

DFU "fixes" the issue by normalizing total to 100% at runtime. It's hard to tell what is more "right", short of investigating classic's assets

@Daneel53

Daneel53 commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator Author

We will never know if the Chronicles are wrong for the Woodlands/Winter values or if these values were already present into DF code. But I checked all the numbers and this entry is the only one where the total is not 100, so there is somewhere a bug.
I decided to add rain in Winter because it seemed not logical with 20% in Autumn and 25% in Spring to have no rain at all in Winter into woods.
Anyway, what is bothering me is the yellow warning that indicates an issue into the code when finally the issue is in the numbers of the table. If we don't want to modifiy one number in the table to respect what is written in the Chronicles, I think that at least we should downgrade the yellow Debug.LogWarning() to a simple grey Debug.Log() into Weather.cs so that we don't think there is a code error to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants