25.7 fb container scoping#1022
Conversation
| if (!selections.isEmpty()) | ||
| { | ||
| // GitHub Kanban #1892: Verify each selected run belongs to the current container before queuing | ||
| for (String selection : selections) |
There was a problem hiding this comment.
nit: We should be cautious of taking data region selections and translating them into single objects / non-aggregate queries. Perhaps the scales here do not warrant change.
There was a problem hiding this comment.
This is the same way that BackgroundSubtractionJob processes the selection values into ExpRun rowIds, so this seems consistent. We could instead push the check down into that BackgroundSubtractionJob.run method if you think that would be better.
| ActionURL url = getViewContext().getActionURL(); | ||
| // Read scriptId from the action URL (falling back to the request parameter) so it resolves under both | ||
| // real browser requests and in-JVM mock dispatch, mirroring how runId/compId below are read from the URL. | ||
| String scriptIdStr = url.getParameter("scriptId"); |
There was a problem hiding this comment.
This should not be necessary given the change made in the platform PR to the mocking to support getParameter().
There was a problem hiding this comment.
Good catch, I'm not sure why claude thought it was necessary to add this code.
#### Rationale Small refactors to help introduce better container scoping checks for NAb actions. #### Related Pull Requests - #7747 - LabKey/commonAssays#1022 - LabKey/testAutomation#3042 --------- Co-authored-by: labkey-nicka <nickk@labkey.com> Co-authored-by: cnathe <cnathe@labkey.com>
#### Rationale Regression tests for the NAb container scoping updates. #### Related Pull Requests - LabKey/platform#7747 - LabKey/commonAssays#1022 - #3042 --------- Co-authored-by: cnathe <cnathe@labkey.com>
3 participants
Rationale
Add permission checks for objects referenced by rowID.
Related Pull Requests