Improve Save Template validation when no fields are selected#1148
Merged
labkey-martyp merged 1 commit intoJun 15, 2026
Merged
Conversation
Submitting the EHR Save As Template dialog with every field unchecked threw an uncaught TypeError because the checkboxgroup's getValue().fields is undefined when nothing is selected, leaving the user with a silent failure and a console error. Guard the field list before reading its length, and check the record selector for 'none' first so a section the user intends to save is distinguished from one explicitly excluded. When no fields are selected, show a clear validation message instead of the generic "No records selected" alert.
labkey-bpatel
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Submitting the EHR "Save As Template" dialog with every field unchecked threw an uncaught
TypeError: Cannot read properties of undefined (reading 'length'). The checkboxgroup'sgetValue().fieldsisundefinedwhen nothing is selected, so reading.lengthcrashedonSubmit— the user got a silent failure (the template was never saved) plus a console error, instead of any guidance.Related Pull Requests
None.
Changes
.length, so an empty selection no longer throws.'none'case before the field check, so a section the user intends to save is distinguished from one explicitly excluded.