Validate list audit event matches URL-requested list, and unit test.#7757
Open
labkey-bpatel wants to merge 1 commit into
Open
Validate list audit event matches URL-requested list, and unit test.#7757labkey-bpatel wants to merge 1 commit into
labkey-bpatel wants to merge 1 commit into
Conversation
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
OWASP Finding:
_listcontainer-resolved, but rendered old/new maps fromAuditLogService.getAuditEvent(user, LIST_AUDIT_EVENT, rowId)global (cf=null); event never tied to list,event.getContainer()uncheckedThe audit details action previously looked up audit events globally by row ID after resolving the requested list, which could allow an event from one list to be displayed in the context of another list. The fix tightens the lookup to the resolved list container and ensures the event is associated with the requested list before returning any record data
Related Pull Requests
Changes
Tasks 📍