Fix PassportTest and improve scoping#1233
Conversation
|
|
||
| /** | ||
| * Container-scoping integration tests for {@link TargetedMSController} actions that resolve an object by a | ||
| * global id. Each test sets up the same object in one folder and confirms the action rejects a request that addresses |
There was a problem hiding this comment.
Comment truncated? Should it be "...that addresses the object through a different folder."?
There was a problem hiding this comment.
Thanks. Fixed.
| @Test | ||
| public void auditLogExtraInfoIsContainerScoped() throws Exception | ||
| { | ||
| UnitTestUtil.cleanupDatabase(DOC_GUID); |
There was a problem hiding this comment.
Is this redundant with @After cleanupAuditLog()?
There was a problem hiding this comment.
Largely, yes. Better to mark that method as both Before and After and remove this call. Done.
| public void waitForElementsAtLeast(final Locator loc, final int count) | ||
| { | ||
| waitFor(() -> loc.findElements(getDriver()).size() >= count, WAIT_FOR_JAVASCRIPT); | ||
| assertTrue("Element not present at least the expected number of times", loc.findElements(getDriver()).size() >= count); |
There was a problem hiding this comment.
loc.findElements(getDriver()).size() is getting called twice.
There was a problem hiding this comment.
True, but one is inside the lambda. We could reuse the result but I think it's a bit cleaner (and reasonable) to check again outside the lambda.
|
@DariaBod FYI, here's the fix for PassportTest. Merged to 25.7 earlier this morning. |
2 participants
Rationale
PassportTest needs an update to expect the updated data being pulled dynamically from UniProt
Changes