Pin spec v0.70.1: wire fixture 110, defer rerank#181
Merged
Conversation
Advance the spec pin v0.69.0 -> v0.70.1 (submodule + the four sync points). v0.70.0 adds proposal 0060 (rerank); v0.70.1 adds observability fixture 110. Wire fixture 110 (proposal 0075 callable-branch span shape) via a new _run_fixture_110 runner. This is the ORIGINAL fixture (span shape + skip-emits-no-span); the branch_count assertion arrives at v0.16.0 with the v0.73.1 pin. Mark 0060 not-yet (rerank is unimplemented until v0.16.0) and defer the 11 rerank observability fixtures (099-109) in both the coverage guard's accounting and the cross-capability fixture parser. Fixture 110 also defers in the parser (it mixes a graph final_state with the span_tree). Regenerate the bundled AGENTS.md for the new pin. No version/CHANGELOG change; both land at the v0.15.0 release.
There was a problem hiding this comment.
Pull request overview
Pins the repo’s openarmature-spec version from v0.69.0 → v0.70.1, updates all spec pin sync points, and updates conformance harness behavior to account for newly pinned observability fixtures (including wiring fixture 110) while explicitly deferring rerank fixtures that depend on an unimplemented capability.
Changes:
- Bump and synchronize spec pin/version across runtime constants,
pyproject.toml,conformance.toml, and the smoke test. - Wire observability conformance fixture 110 via a dedicated runner that validates the callable-branch span shape + “when-skipped emits no span”.
- Explicitly defer rerank observability fixtures 099–109 in both the observability harness accounting and the cross-capability fixture parser.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
tests/test_smoke.py |
Updates the smoke assertion to the new __spec_version__. |
tests/conformance/test_observability.py |
Accounts for rerank fixtures as deferred, adds fixture 110 to supported set, and implements _run_fixture_110. |
tests/conformance/test_fixture_parsing.py |
Defers parsing for rerank fixtures (099–109) and fixture 110 due to cross-capability expected-shape mismatch. |
src/openarmature/AGENTS.md |
Regenerated bundled agent docs header to reflect the new spec pin. |
src/openarmature/__init__.py |
Updates __spec_version__ to 0.70.1. |
pyproject.toml |
Updates [tool.openarmature].spec_version to 0.70.1. |
conformance.toml |
Updates [manifest].spec_pin to v0.70.1 and adds proposal 0060 as not-yet. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
PR #181 review: _run_fixture_110_case fetched the invocation root span with next() and no default, so a missing root failed with a bare StopIteration. Match _run_fixture_038_case: next((...), None) plus an explicit assert that reports the span names found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Advances the spec pin v0.69.0 -> v0.70.1. The delta brings proposal 0060 (retrieval-provider rerank, v0.70.0) and observability conformance fixture 110 (the proposal 0075 callable-branch span shape, v0.70.1).
Changes
__spec_version__,pyproject.toml [tool.openarmature].spec_version,conformance.toml [manifest].spec_pin, and the smoke-test assertion._run_fixture_110): the callable-branch span shape renders one per-branch dispatch span keyed bybranch_namewith no inner-node spans, and awhen-skipped branch emits no span. This is the ORIGINAL fixture 110 (span shape + skip-emits-no-span); thebranch_countassertion arrives at v0.16.0 with the v0.73.1 pin, per the v0.15.0 release review.not-yetand the 11 rerank observability fixtures (099-109) deferred -- rerank is unimplemented in python until v0.16.0. The deferrals land in both the coverage guard's accounting (_DEFERRED_FIXTURES) and the cross-capability fixture parser. Fixture 110 also defers in the parser (it mixes a graphfinal_statewith the observabilityspan_tree); it runs via_run_fixture_110.No
__version__or CHANGELOG change -- phase work; both land at the v0.15.0 release.Validation
Full suite green (1446 passed, 424 skipped); ruff + pyright clean; manifest check OK (75/75 proposals). Observability conformance: 54 run, 58 documented-skip. The #180 coverage guard enforced the rerank deferrals.