Feature/sponsor rewards a11y fix#24
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
Improves the sponsor rewards “flip card” UI with better semantics and motion-reduction handling, and ensures navbar scroll-driven UI state is synchronized correctly on initial render.
Changes:
- Adds keyboard-accessible flip interaction and updates reward descriptions to support richer markup (lists) in
SponsorRewards. - Adds
prefers-reduced-motionstyling for the flip interaction. - Initializes scroll-derived UI state immediately in
App/Navbareffects to avoid a stale first render.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/components/SponsorRewards.tsx | Adds accessible flip interactions, richer reward description content, and reduced-motion styling (with a couple of state/ARIA consistency issues to address). |
| src/App.tsx | Syncs scroll-based navbar/ticker state immediately on mount to prevent incorrect initial UI. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+13
to
+20
| const [isMobileView, setIsMobileView] = useState(false); | ||
|
|
||
| useEffect(() => { | ||
| const checkMobile = () => setIsMobileView(window.innerWidth < 768); | ||
| checkMobile(); | ||
| window.addEventListener('resize', checkMobile); | ||
| return () => window.removeEventListener('resize', checkMobile); | ||
| }, []); |
Comment on lines
+242
to
+250
| @media (prefers-reduced-motion: reduce) { | ||
| .flip-card { | ||
| transition: none; | ||
| } | ||
| .flip-hint-icon { | ||
| animation: none; | ||
| } | ||
| } | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.