fix: resolve GitHub logo navbar overlap on mobile, tablet and iPad Mini#26
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR adjusts the hero section’s top spacing and positioning to prevent the GitHub logo/title block from overlapping the site’s fixed navigation on smaller viewports (mobile/tablet/iPad Mini).
Changes:
- Switches nav element selection used for measuring top offset/height (
header→nav) and updates the measurement used for padding calculations. - Tweaks hero padding-top values to reduce/adjust spacing under the navbar on non-XL viewports.
- Removes a medium-breakpoint upward translate on the hero title block to avoid pushing it into the navbar area.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+72
to
+73
| const navEl = typeof document !== 'undefined' ? document.querySelector('nav') : null; | ||
| const measuredNavHeight = navEl ? Math.round(navEl.getBoundingClientRect().bottom) : 0; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.