Set previous focus target to editor that opens drawer#4562
Merged
Conversation
Coverage Report for CI Build 28169320711Warning No base build found for commit Coverage: 59.037%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Qt's
Popup(and its subclassesDrawer,Dialog) savesWindow.activeFocusItemwhenopen()is called and restores it when the popup closes. In forms with a text editor above a dropdown or date field, the editor often held active focus at the moment the drawer opened - so on close, focus was returned to it, raising the on-screen keyboard and pushing content out of view.Fix: call
forceActiveFocus()on the editor component immediately before activating the Loader. This moves active focus to the component that logically "owns" the interaction, so the Popup saves it as the restore target. On close, focus returns to that component - not to a text editor further up the form.Applied to:
Fixes #4522