DownloadManager: document redact_url kwarg#6
Open
bitcoin3us wants to merge 1 commit into
Open
Conversation
Companion to MicroPythonOS#136 (adds the kwarg to DownloadManager.download_url). Adds a new "Redacting Sensitive URLs" section explaining when callers should opt in, what gets redacted (URL path/query, response-headers, exception messages — host kept for failure triage), and why the default is False (preserves useful debug output for public-URL callers). Updates the parameters table with the new kwarg. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Companion to MicroPythonOS#136 which adds a
redact_url=Falsekwarg toDownloadManager.download_url. This documents:Falseredact_url=True: API-key-in-URL, OAuth-token-in-URL, wallet xpubs in indexer URLs, LNBits readkey pathsWhy
Motivating case in the wild: LightningPiggyApp PR #25/#26 on-chain wallet queries Blockbook with the xpub in the URL path. The Lightning Piggy app scrubs xpubs from its own logs, but
DownloadManager's built-in URL logging was re-leaking the xpub on every poll. The kwarg gives callers a clean opt-in to hide the secret-bearing portion.Test plan