Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions platformio.ini
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
; default_envs = esp32c3dev
; default_envs = lolin_s2_mini
; default_envs = esp32s3dev_16MB_PSRAM_opi
; default_envs = esp32s3_16MB_OPI

; MoonModules entries
; ===================
Expand Down Expand Up @@ -105,6 +106,7 @@ default_envs =
esp32S3_8MB_PSRAM_M_qspi ;; for S3 with 8MB flash, 2 or 4MB PSRAM, HUB75 supported
esp32S3_8MB_PSRAM_M_opi ;; for S3 with 8MB flash, 8 or 16MB PSRAM, HUB75 supported
;; === esp32-S3 === with 16MB flash
esp32s3_16MB_OPI
Comment thread
coderabbitai[bot] marked this conversation as resolved.
esp32S3_16MB_PSRAM_M_HUB75 ;; for S3 with 16MB flash, HUB75 supported (MOONHUB HUB75 adapter board)
esp32S3_WROOM-2_M ;; for S3 WROOM-2; HUB75 supported
;;
Expand Down
17 changes: 17 additions & 0 deletions wled00/wled.h
Original file line number Diff line number Diff line change
@@ -1,3 +1,20 @@
#ifndef WLED_MY_PINS
#define WLED_MY_PINS
#define R1_PIN 42
#define G1_PIN 41
#define B1_PIN 40
#define R2_PIN 39
#define G2_PIN 38
#define B2_PIN 45
#define A_PIN 1
#define B_PIN 2
#define C_PIN 3
#define D_PIN 4
#define E_PIN 5
#define LAT_PIN 6
#define OE_PIN 7
#define CLK_PIN 8
#endif
Comment on lines +1 to +17

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Align this pinout with the Matrixboard wiring contract.

These values don’t match the HUB75 pin order documented in bus_manager.cpp, so the matrix driver will be wired incorrectly on the target board. Please verify the mapping against the actual board schematic, and scope this block to the Matrixboard build only if this header is shared by other targets.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@wled00/wled.h` around lines 1 - 17, The pin definitions (R1_PIN, G1_PIN,
B1_PIN, R2_PIN, G2_PIN, B2_PIN, A_PIN, B_PIN, C_PIN, D_PIN, E_PIN, LAT_PIN,
OE_PIN, CLK_PIN) in the WLED_MY_PINS block do not match the HUB75 pin order
documented in bus_manager.cpp. Verify the correct pin mapping against the board
schematic and update each pin definition to match the proper HUB75 wiring order.
Additionally, if this header file is used by multiple build targets, scope the
WLED_MY_PINS block with a conditional preprocessor directive to apply these pin
definitions only to the Matrixboard build.

#ifndef WLED_H
#define WLED_H
/*
Expand Down