Skip to content

Release v09#108

Draft
georgeRobertson wants to merge 7 commits into
mainfrom
release_v09
Draft

Release v09#108
georgeRobertson wants to merge 7 commits into
mainfrom
release_v09

Merge pull request #116 from NHSDigital/fix/gr-regression_fixes_post_…

bb3d1c7
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Jun 23, 2026 in 38s

Annotations

Check warning on line 147 in src/dve/core_engine/backends/utilities.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment.

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AZ5qRgpu6j7Y6XsS5w90&open=AZ5qRgpu6j7Y6XsS5w90&pullRequest=108

Check warning on line 677 in src/dve/metadata_parser/domain_types.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment.

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AZ5qRguU6j7Y6XsS5w9_&open=AZ5qRguU6j7Y6XsS5w9_&pullRequest=108

Check warning on line 54 in src/dve/core_engine/backends/readers/xml.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Merge this if statement with the enclosing one.

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AZ5qRgpL6j7Y6XsS5w9z&open=AZ5qRgpL6j7Y6XsS5w9z&pullRequest=108

Check warning on line 37 in src/dve/core_engine/models.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment.

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AZ5qRgso6j7Y6XsS5w93&open=AZ5qRgso6j7Y6XsS5w93&pullRequest=108

Check warning on line 51 in src/dve/core_engine/backends/implementations/spark/spark_helpers.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment.

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AZ5qRgoQ6j7Y6XsS5w9y&open=AZ5qRgoQ6j7Y6XsS5w9y&pullRequest=108

Check warning on line 269 in src/dve/core_engine/message.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment.

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AZ5qRgs86j7Y6XsS5w94&open=AZ5qRgs86j7Y6XsS5w94&pullRequest=108

Check warning on line 60 in src/dve/core_engine/engine.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment.

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AZ5qRgqi6j7Y6XsS5w91&open=AZ5qRgqi6j7Y6XsS5w91&pullRequest=108

Check warning on line 427 in src/dve/metadata_parser/domain_types.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment.

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AZ5qRguU6j7Y6XsS5w99&open=AZ5qRguU6j7Y6XsS5w99&pullRequest=108

Check warning on line 274 in src/dve/metadata_parser/domain_types.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment.

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AZ5qRguU6j7Y6XsS5w97&open=AZ5qRguU6j7Y6XsS5w97&pullRequest=108

Check warning on line 85 in src/dve/core_engine/validation.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Fix this call; Previous type checks suggest that this expression has type BaseModel and it is not callable.

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AZ5qRgq16j7Y6XsS5w92&open=AZ5qRgq16j7Y6XsS5w92&pullRequest=108

Check warning on line 270 in src/dve/core_engine/message.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment.

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AZ5qRgs86j7Y6XsS5w95&open=AZ5qRgs86j7Y6XsS5w95&pullRequest=108

Check failure on line 57 in src/dve/metadata_parser/model_generator.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unexpected named argument 'pattern'.

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AZ5qRgun6j7Y6XsS5w-B&open=AZ5qRgun6j7Y6XsS5w-B&pullRequest=108

Check warning on line 404 in src/dve/metadata_parser/domain_types.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment.

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AZ5qRguU6j7Y6XsS5w98&open=AZ5qRguU6j7Y6XsS5w98&pullRequest=108

Check warning on line 457 in src/dve/metadata_parser/domain_types.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this commented out code.

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AZ5qRguU6j7Y6XsS5w9-&open=AZ5qRguU6j7Y6XsS5w9-&pullRequest=108

Check warning on line 706 in src/dve/metadata_parser/domain_types.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment.

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AZ5qRguU6j7Y6XsS5w-A&open=AZ5qRguU6j7Y6XsS5w-A&pullRequest=108