BCSS-23562 - feat(ecs-cluster): add new ecs-cluster module#51
Open
dave4420 wants to merge 13 commits into
Open
BCSS-23562 - feat(ecs-cluster): add new ecs-cluster module#51dave4420 wants to merge 13 commits into
dave4420 wants to merge 13 commits into
Conversation
nhs-oliverslater
added
enhancement
nhs-oliverslater
changed the title
- Introduced a new context.tf file to standardize tagging and naming conventions. - Removed ecs.tf and migrated ECS cluster resource definitions to main.tf using the community ECS cluster module. - Added locals.tf to derive cluster name and CloudWatch log group configurations. - Updated outputs.tf to reflect new output values from the ECS cluster module. - Removed the readme.md file as it was outdated and no longer needed. - Enhanced variables.tf with new variables for ECS cluster configuration, including CloudWatch log group settings and capacity providers. - Updated versions.tf to include the time provider and adjust the AWS provider version. BREAKING CHANGE: Removes original ecs-cluster module that had nested resources i.e. aws_security_group, aws_iam_service_linked_role, aws_sns_topic, aws_cloudwatch_metric_alarm.
nhs-oliverslater
force-pushed
the
feature/BCSS-23562-ecs-cluster-tf-submodule
branch
from
cc647f9 to
87bcbc4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.