BCSS-23409 - feat(elasticache)!: create elasticache module#93
Open
nhs-oliverslater wants to merge 6 commits into
Open
BCSS-23409 - feat(elasticache)!: create elasticache module#93nhs-oliverslater wants to merge 6 commits into
nhs-oliverslater wants to merge 6 commits into
Conversation
…eployment modes (replication_group, cluster, serverless) - Updated locals.tf to define deployment modes and naming conventions. - Enhanced main.tf to configure ElastiCache resources based on deployment mode. - Added outputs for replication group, cluster, and serverless cache details. - Removed deprecated readme.md and updated variables.tf with comprehensive input descriptions. - Improved validation for engine types, deployment modes, and snapshot configurations. - Adjusted versions.tf to require compatible provider versions. BREAKING CHANGE: Replaces exisiting module, replaces all explicit and implicit resources and changes upstream module version. All resources will be re-created.
…up family and enhance logging configuration
… simplify security group handling
dave4420
changed the title
dave4420
reviewed
Jun 23, 2026
Comment on lines
+125
to
+127
| # TODO: Pre-create log groups via the cloudwatch module for stronger | ||
| # control over KMS key, retention class, and skip_destroy behaviour. Example | ||
| # using terraform-aws-modules/cloudwatch/aws//modules/log-group: |
Contributor
There was a problem hiding this comment.
Is this something we need to do before merging?
Or something we're doing in a follow up PR/ticket?
If it's tech debt, could you raise a ticket and include the ticket number in the comment, please?
Comment on lines
+323
to
+330
| ## Exemplar Modules | ||
|
|
||
| Reference these for patterns: | ||
|
|
||
| - [s3-bucket](../s3-bucket) — full wrapper with comprehensive security | ||
| - [kms](../kms) — customer-managed key creation | ||
| - [security-group](../security-group) — security group patterns | ||
| - [sns](../sns) — notification topic setup |
Contributor
There was a problem hiding this comment.
Should this be part of the README for an individual module?
Comment on lines
+332
to
+343
| ## Terraform Validation | ||
|
|
||
| ```bash | ||
| # Format | ||
| terraform fmt -recursive infrastructure/modules/elasticache | ||
|
|
||
| # Initialize (required for validate) | ||
| terraform -chdir=infrastructure/modules/elasticache init | ||
|
|
||
| # Validate | ||
| terraform -chdir=infrastructure/modules/elasticache validate | ||
| ``` |
Contributor
There was a problem hiding this comment.
Again, this doesn't feel like it should be part of consuming developer—facing documentation?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactor the ElastiCache module to support multiple deployment modes, simplify security group handling, and enhance logging configuration. Update the gitleaks configuration for improved IPv4 and IPv6 rule handling. Align the context.tf file and update documentation for case sensitivity.
Context
These changes are required to improve the flexibility and usability of the ElastiCache module, allowing for various deployment configurations while ensuring better security practices and logging capabilities.
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT include any PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that does contain any sensitive information. We really appreciate your cooperation in this matter.