Skip to content

test(sandbox): reject malformed proxy hostnames#1562

Open
mjamiv wants to merge 1 commit into
NVIDIA:mainfrom
mjamiv:test/proxy-hostname-parser-differentials
Open

test(sandbox): reject malformed proxy hostnames#1562
mjamiv wants to merge 1 commit into
NVIDIA:mainfrom
mjamiv:test/proxy-hostname-parser-differentials

Conversation

@mjamiv
Copy link
Copy Markdown
Contributor

@mjamiv mjamiv commented May 25, 2026

Summary

  • reject malformed CONNECT host authorities before policy/DNS handling
  • make OPA network evaluation fail closed for unsafe host strings
  • add regression coverage for NUL/control, percent-encoded, slash, and backslash hostname differentials against wildcard policies

Fixes #1498.

Testing

  • cargo fmt --all -- --check
  • git diff --check
  • cargo test -p openshell-sandbox malformed
  • cargo test -p openshell-sandbox --lib

@mjamiv mjamiv requested review from a team, derekwaynecarr, maxamillion and mrunalp as code owners May 25, 2026 21:56
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented May 25, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test: add regression coverage for proxy hostname parser differentials

1 participant