Skip to content

[no-ci] Follow-on to cuda.core AGENTS.md#2113

Merged
rwgk merged 2 commits into
NVIDIA:mainfrom
mdboom:agents-part2
May 21, 2026
Merged

[no-ci] Follow-on to cuda.core AGENTS.md#2113
rwgk merged 2 commits into
NVIDIA:mainfrom
mdboom:agents-part2

Conversation

@mdboom
Copy link
Copy Markdown
Contributor

@mdboom mdboom commented May 19, 2026

This is a follow up to #2107 based on this comment and an offline discussion about typing.TYPE_CHECK.

@mdboom mdboom requested a review from leofang May 19, 2026 22:44
@mdboom mdboom self-assigned this May 19, 2026
@github-actions github-actions Bot added the cuda.core Everything related to the cuda.core module label May 19, 2026
@mdboom mdboom added the enhancement Any code-related improvements label May 19, 2026
@github-actions

This comment has been minimized.

Copy link
Copy Markdown
Contributor

@rwgk rwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd reword, in style of an actual guidance, but LGTM otherwise.

Comment thread cuda_core/AGENTS.md Outdated
@leofang leofang changed the title Follow-on to cuda.core AGENTS.md [no-ci] Follow-on to cuda.core AGENTS.md May 20, 2026
@leofang
Copy link
Copy Markdown
Member

leofang commented May 20, 2026

LGTM but I'd let @Andy-Jost take a look on TYPE_CHECKING as he seems to have reservation based on the offline chat.

@leofang leofang requested a review from Andy-Jost May 20, 2026 02:10
@leofang leofang added this to the cuda.core v1.1.0 milestone May 20, 2026
@Andy-Jost
Copy link
Copy Markdown
Contributor

LGTM but I'd let @Andy-Jost take a look on TYPE_CHECKING as he seems to have reservation based on the offline chat.

The wording here looks fine to me. Regarding TYPE_CHECKING, I'm mostly confused. I'm looking for rules (a), (b), (c), ... such that following them avoids certain identifiable problems, e.g., with circular imports, tools relying on type annotations, and so on. The rules would probably need to cover package structure, __init__.py file contents, TYPE_CHECKING blocks, and other [c]import guidelines.

AFAICT, we have not identified either the rules or even the complete list of problems we need to avoid. None of that should gate this PR, though.

@rwgk rwgk added the P1 Medium priority - Should do label May 21, 2026
@rwgk rwgk merged commit caf05e6 into NVIDIA:main May 21, 2026
98 of 100 checks passed
@github-actions
Copy link
Copy Markdown

Doc Preview CI
Preview removed because the pull request was closed or merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cuda.core Everything related to the cuda.core module enhancement Any code-related improvements P1 Medium priority - Should do

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants