feat: [SDK-4774] add OneSignal project settings support#880
Merged
Conversation
Add per-demo cleanup helpers so generated build state and OneSignal dependency manifests can be cleared before testing Editor-side regeneration. Co-authored-by: Cursor <cursoragent@cursor.com>
abdulraqeeb33
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Adds a Project Settings page for OneSignal SDK configuration and cleans up Unity demo setup artifacts.
Details
Motivation
The location module opt-out is a persistent project-level SDK setting, so it should be discoverable from Unity's Project Settings instead of only through a menu-bar toggle. This PR also keeps the demo projects reproducible after running SDK setup by checking in generated demo assets and adding cleanup scripts.
Scope
Adds
Project Settings > OneSignalfor the Disable Location Module setting and removes the oldOneSignal > Disable Location Modulemenu item so Project Settings is the single interactive UI path. Updates Unity demo setup files, generated EDM4U/Android plugin assets fordemo-no-location, adds demo cleanup scripts, bumps package Unity metadata to the supported2021.3minimum, and replaces obsolete iOSGetApplicationIdentifier(BuildTargetGroup.iOS)calls withNamedBuildTarget.iOS.Testing
Unit testing
No unit tests were added; these changes are Unity Editor UI, demo setup, package metadata, and generated demo asset updates.
Manual testing
Tested the following Unity demo build paths:
examples/demovia Unity Editor for iOS and Android.examples/demo-no-locationvia Unity Editor for iOS and Android.examples/demovia build scripts:run-android.shandrun-ios.sh.examples/demo-no-locationvia build scripts:run-android.shandrun-ios.sh.Also verified the location opt-out is configured from
Project Settings > OneSignalafter removing the menu-bar toggle. Remaining Unity Editor Analytics deprecation warnings inVSAttribution.csare pre-existing and intentionally left unchanged.Affected code checklist
Checklist
Overview
Testing
Final pass