Remove obsolete openam-test integration test suite#1055
Open
vharseko wants to merge 1 commit into
Open
Conversation
vharseko
force-pushed
the
issues/openam-test
branch
from
4b869d5 to
922e3cd
Compare
Contributor
|
There are some test cases which could be useful in e2e tests. I think before removing the module, we could port tests to the e2e suite |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delete the openam-test module entirely. It was an in-process TestNG
suite whose TestBase static initializer bootstrapped a full OpenAM
instance (Bootstrap.load) and called System.exit(1) when no configured
instance with a reachable configuration store was available, so the
tests could never run as part of a normal build.
The module was never registered in the Maven reactor and had been
unmaintained since the 10.2.0 era. Several tests referenced APIs that
no longer exist: the removed ssoadm policy/realm commands
(ListPolicyNames, RealmGetPolicy, RealmDeletePolicy) and the static
ApplicationManager, replaced by the Guice-based ApplicationServiceFactory.