Skip to content

security(cr): add record rules to CR detail models (ownership + area) #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
gonzalesedwin1123 wants to merge 2 commits into
base: 19.0
Choose a base branch
from
Draft

security(cr): add record rules to CR detail models (ownership + area) #261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47b7df9
security(cr): add record rules to detail models to enforce CR ownership
gonzalesedwin1123 Jul 1, 2026
d9a8947
security(cr): mirror parent area filter to detail models + harden test
gonzalesedwin1123 Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
174 changes: 174 additions & 0 deletions spp_change_request_v2/security/area_filter_rules.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,4 +31,178 @@ can be referenced without defensive guards.
<field name="perm_create" eval="True" />
<field name="perm_unlink" eval="True" />
</record>

<!--
Mirror the parent CR area filter onto each detail model. Detail models
are separate tables and do NOT inherit the parent's global area rule, so
without these an area-scoped officer could reach (via RPC) detail rows of
change requests whose registrant is outside their center area, even though
the parent CR is hidden. Global rule (no groups) so it ANDs with the
ownership rules; users without center areas are unaffected (empty domain).
-->

<record id="rule_cr_detail_add_member_area_filter" model="ir.rule">
<field
name="name"
>CR Detail (add_member): visible only within user's center areas</field>
<field name="model_id" ref="model_spp_cr_detail_add_member" />
<field
name="domain_force"
>[('change_request_id.registrant_id.area_id', 'child_of', user.center_area_ids.ids)] if user.center_area_ids else []</field>
<field name="global" eval="True" />
<field name="perm_read" eval="True" />
<field name="perm_write" eval="True" />
<field name="perm_create" eval="True" />
<field name="perm_unlink" eval="True" />
</record>

<record id="rule_cr_detail_edit_individual_area_filter" model="ir.rule">
<field
name="name"
>CR Detail (edit_individual): visible only within user's center areas</field>
<field name="model_id" ref="model_spp_cr_detail_edit_individual" />
<field
name="domain_force"
>[('change_request_id.registrant_id.area_id', 'child_of', user.center_area_ids.ids)] if user.center_area_ids else []</field>
<field name="global" eval="True" />
<field name="perm_read" eval="True" />
<field name="perm_write" eval="True" />
<field name="perm_create" eval="True" />
<field name="perm_unlink" eval="True" />
</record>

<record id="rule_cr_detail_edit_group_area_filter" model="ir.rule">
<field
name="name"
>CR Detail (edit_group): visible only within user's center areas</field>
<field name="model_id" ref="model_spp_cr_detail_edit_group" />
<field
name="domain_force"
>[('change_request_id.registrant_id.area_id', 'child_of', user.center_area_ids.ids)] if user.center_area_ids else []</field>
<field name="global" eval="True" />
<field name="perm_read" eval="True" />
<field name="perm_write" eval="True" />
<field name="perm_create" eval="True" />
<field name="perm_unlink" eval="True" />
</record>

<record id="rule_cr_detail_remove_member_area_filter" model="ir.rule">
<field
name="name"
>CR Detail (remove_member): visible only within user's center areas</field>
<field name="model_id" ref="model_spp_cr_detail_remove_member" />
<field
name="domain_force"
>[('change_request_id.registrant_id.area_id', 'child_of', user.center_area_ids.ids)] if user.center_area_ids else []</field>
<field name="global" eval="True" />
<field name="perm_read" eval="True" />
<field name="perm_write" eval="True" />
<field name="perm_create" eval="True" />
<field name="perm_unlink" eval="True" />
</record>

<record id="rule_cr_detail_change_hoh_area_filter" model="ir.rule">
<field
name="name"
>CR Detail (change_hoh): visible only within user's center areas</field>
<field name="model_id" ref="model_spp_cr_detail_change_hoh" />
<field
name="domain_force"
>[('change_request_id.registrant_id.area_id', 'child_of', user.center_area_ids.ids)] if user.center_area_ids else []</field>
<field name="global" eval="True" />
<field name="perm_read" eval="True" />
<field name="perm_write" eval="True" />
<field name="perm_create" eval="True" />
<field name="perm_unlink" eval="True" />
</record>

<record id="rule_cr_detail_exit_registrant_area_filter" model="ir.rule">
<field
name="name"
>CR Detail (exit_registrant): visible only within user's center areas</field>
<field name="model_id" ref="model_spp_cr_detail_exit_registrant" />
<field
name="domain_force"
>[('change_request_id.registrant_id.area_id', 'child_of', user.center_area_ids.ids)] if user.center_area_ids else []</field>
<field name="global" eval="True" />
<field name="perm_read" eval="True" />
<field name="perm_write" eval="True" />
<field name="perm_create" eval="True" />
<field name="perm_unlink" eval="True" />
</record>

<record id="rule_cr_detail_transfer_member_area_filter" model="ir.rule">
<field
name="name"
>CR Detail (transfer_member): visible only within user's center areas</field>
<field name="model_id" ref="model_spp_cr_detail_transfer_member" />
<field
name="domain_force"
>[('change_request_id.registrant_id.area_id', 'child_of', user.center_area_ids.ids)] if user.center_area_ids else []</field>
<field name="global" eval="True" />
<field name="perm_read" eval="True" />
<field name="perm_write" eval="True" />
<field name="perm_create" eval="True" />
<field name="perm_unlink" eval="True" />
</record>

<record id="rule_cr_detail_update_id_area_filter" model="ir.rule">
<field
name="name"
>CR Detail (update_id): visible only within user's center areas</field>
<field name="model_id" ref="model_spp_cr_detail_update_id" />
<field
name="domain_force"
>[('change_request_id.registrant_id.area_id', 'child_of', user.center_area_ids.ids)] if user.center_area_ids else []</field>
<field name="global" eval="True" />
<field name="perm_read" eval="True" />
<field name="perm_write" eval="True" />
<field name="perm_create" eval="True" />
<field name="perm_unlink" eval="True" />
</record>

<record id="rule_cr_detail_create_group_area_filter" model="ir.rule">
<field
name="name"
>CR Detail (create_group): visible only within user's center areas</field>
<field name="model_id" ref="model_spp_cr_detail_create_group" />
<field
name="domain_force"
>[('change_request_id.registrant_id.area_id', 'child_of', user.center_area_ids.ids)] if user.center_area_ids else []</field>
<field name="global" eval="True" />
<field name="perm_read" eval="True" />
<field name="perm_write" eval="True" />
<field name="perm_create" eval="True" />
<field name="perm_unlink" eval="True" />
</record>

<record id="rule_cr_detail_merge_registrants_area_filter" model="ir.rule">
<field
name="name"
>CR Detail (merge_registrants): visible only within user's center areas</field>
<field name="model_id" ref="model_spp_cr_detail_merge_registrants" />
<field
name="domain_force"
>[('change_request_id.registrant_id.area_id', 'child_of', user.center_area_ids.ids)] if user.center_area_ids else []</field>
<field name="global" eval="True" />
<field name="perm_read" eval="True" />
<field name="perm_write" eval="True" />
<field name="perm_create" eval="True" />
<field name="perm_unlink" eval="True" />
</record>

<record id="rule_cr_detail_split_household_area_filter" model="ir.rule">
<field
name="name"
>CR Detail (split_household): visible only within user's center areas</field>
<field name="model_id" ref="model_spp_cr_detail_split_household" />
<field
name="domain_force"
>[('change_request_id.registrant_id.area_id', 'child_of', user.center_area_ids.ids)] if user.center_area_ids else []</field>
<field name="global" eval="True" />
<field name="perm_read" eval="True" />
<field name="perm_write" eval="True" />
<field name="perm_create" eval="True" />
<field name="perm_unlink" eval="True" />
</record>
</odoo>
Loading
Loading