chore(codecov): ignore module manifests in coverage#283
Open
gonzalesedwin1123 wants to merge 1 commit into
Open
chore(codecov): ignore module manifests in coverage#283gonzalesedwin1123 wants to merge 1 commit into
gonzalesedwin1123 wants to merge 1 commit into
Conversation
Odoo reads __manifest__.py via ast.literal_eval — the file is never imported, so its lines can never be executed. coverage.py still lists it (source-based collection), making every PR that adds a module show a spurious missing line.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the codecov.yml configuration to ignore manifest.py files from code coverage reporting. I have no feedback to provide as the change is straightforward and there are no review comments.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manifests are read via
ast.literal_eval, never imported, so their lines can never execute. The source-based coverage collection still lists them, which makes every PR adding a module report a spurious uncovered manifest line (seen on #273 and #277). Adds**/__manifest__.pyto the existing codecov ignore list alongside**/tests/**. Config-only; no runtime impact.