Conversation
fixes #150 Signed-off-by: Robert Waffen <rw@betadots.de>
|
@bootc pls have a look |
| if [ "$OPENVOX_USER_GID" -eq 999 ]; then | ||
| OPENVOX_GROUP=ping | ||
| else | ||
| OPENVOX_GROUP=puppet | ||
| fi |
There was a problem hiding this comment.
This looks very odd, what's that about? On Alpine, if the OPENVOX_USER_GID is 999, the OPENVOX_GROUP should be called ping?
There was a problem hiding this comment.
Oh this is because of #150 (comment). Tricky. I wonder whether the answer is to just have different UID/GID numbers on Ubuntu vs Alpine?
There was a problem hiding this comment.
When alpine and desired gid 999 use the name ping for the group. Because it already exists it is not required to create it. If not 999 use puppet as group name and create it.
|
Hi @rwaffen this PR definitely fixes the bug, but I do think that it might be better to have UID/GID 999 for the Ubuntu image like it has always been, and 1001 for Alpine as that's what that image started out with, plus it wouldn't conflict with the existing |
|
two different uid/gid, no. but document changes better, yes. use this approach, also no. will close this one here. maybe #157 is a better solution. 🤔 |
fixes #150
This might be breaking for all users who have used the newer images after #131 . We have mistakenly switched the uid/gid to 1001 and are now reverting it back to 999.
Checklist
I have:
Signed-off-byannotation to each of my commitsGenerated-byorAssisted-byannotations to each of my commits created with the help of an AI agent