Skip to content

fix: revert to uid/gid 999#152

Closed
rwaffen wants to merge 1 commit into
mainfrom
fix_uid
Closed

fix: revert to uid/gid 999#152
rwaffen wants to merge 1 commit into
mainfrom
fix_uid

Conversation

@rwaffen

@rwaffen rwaffen commented Jun 23, 2026

Copy link
Copy Markdown
Member

fixes #150

This might be breaking for all users who have used the newer images after #131 . We have mistakenly switched the uid/gid to 1001 and are now reverting it back to 999.

Checklist

I have:

fixes #150

Signed-off-by: Robert Waffen <rw@betadots.de>
@rwaffen rwaffen requested a review from a team as a code owner June 23, 2026 15:14
@rwaffen rwaffen added bug Something isn't working backwards-incompatible labels Jun 23, 2026
@rwaffen

rwaffen commented Jun 23, 2026

Copy link
Copy Markdown
Member Author

@bootc pls have a look

Comment on lines +7 to +11
if [ "$OPENVOX_USER_GID" -eq 999 ]; then
OPENVOX_GROUP=ping
else
OPENVOX_GROUP=puppet
fi

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very odd, what's that about? On Alpine, if the OPENVOX_USER_GID is 999, the OPENVOX_GROUP should be called ping?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh this is because of #150 (comment). Tricky. I wonder whether the answer is to just have different UID/GID numbers on Ubuntu vs Alpine?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When alpine and desired gid 999 use the name ping for the group. Because it already exists it is not required to create it. If not 999 use puppet as group name and create it.

@bootc

bootc commented Jun 26, 2026

Copy link
Copy Markdown
Member

Hi @rwaffen this PR definitely fixes the bug, but I do think that it might be better to have UID/GID 999 for the Ubuntu image like it has always been, and 1001 for Alpine as that's what that image started out with, plus it wouldn't conflict with the existing ping group. We'd need to clearly document that the difference exists but I think that would be perfectly fine, myself.

@rwaffen

rwaffen commented Jun 29, 2026

Copy link
Copy Markdown
Member Author

two different uid/gid, no. but document changes better, yes. use this approach, also no. will close this one here. maybe #157 is a better solution. 🤔

@rwaffen rwaffen closed this Jun 29, 2026
@rwaffen rwaffen deleted the fix_uid branch June 29, 2026 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Breaking change: puppet UID/GID changed 999 -> 1001 in #141 with no migration path

2 participants