Add puppetfile option to bolt-project.yaml#263
Draft
op-ct wants to merge 8 commits into
Draft
Conversation
Signed-off-by: Chris Tessmer <chris.tessmer@onyxpoint.com>
Signed-off-by: Chris Tessmer <chris.tessmer@onyxpoint.com>
Assisted-by: Claude Opus 4.7 Signed-off-by: Chris Tessmer <chris.tessmer@onyxpoint.com>
Assisted-by: Claude Opus 4.7 Signed-off-by: Chris Tessmer <chris.tessmer@onyxpoint.com>
Assisted-by: Claude Opus 4.7 Signed-off-by: Chris Tessmer <chris.tessmer@onyxpoint.com>
Assisted-by: Claude Opus 4.7 Signed-off-by: Chris Tessmer <chris.tessmer@onyxpoint.com>
The spec tests fails when run ion Windows hosts, because the Windows Ruby `File.expand_path()` prepends the drive letter. The spec test now does expands both sides so the comparison is sound regardless of OS. Assisted-by: Claude Opus 4.7 Signed-off-by: Chris Tessmer <chris.tessmer@onyxpoint.com>
jay7x
reviewed
Jul 1, 2026
| # modules. | ||
| # | ||
| def write(path, moduledir = nil) | ||
| FileUtils.mkdir_p(File.dirname(path)) |
Contributor
There was a problem hiding this comment.
Shall we limit this to be a subdir of the current dir only maybe? I'm not sure if it's good idea to allow specifying literally any file path as a Puppetfile.
E.g. if Bob creates a repo with puppetfile set to /etc/shadow and then give that to Alice. Alice runs bolt module install and got their workstation broken.
I'm not sure what is our strategy here.
Contributor
Author
There was a problem hiding this comment.
Good catch (and may god have mercy on Alice if she installs modules with sudo and --force).
I was thinking about subdirs within the project directory, so I'll restrict it to that
Contributor
Author
|
Temporarily set to "draft" while working through GHA test failures (related: #264) |
Throw a validation error if a bolt-project.yaml 'puppetfile' option isn't a relative path that resolves to inside the poroject directory. Assisted-by: Claude Opus 4.7 Signed-off-by: Chris Tessmer <chris.tessmer@onyxpoint.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds support and tests for a
puppetfileoption inbolt-project.yamlto specify an alternate Puppetfile name/location from the (presently unchangeable)<project dir>/Puppetfilegenerated bybolt module installand edited bybolt module add. This will enable openbolt projects in control repositories to define their requirements separately from the Puppet-managed infrastructure.Assisted-by: Claude Opus 4.7, on a tight leash
Fixes #262
Checklist
I have:
Signed-off-byannotation to each of my commitsGenerated-byorAssisted-byannotations to each of my commits created with the help of an AI agentregressionintegration test(s)