Tweak error messages in E2E test to match updats in SGS#100
Open
Ameobea wants to merge 2 commits into
Open
Conversation
Ameobea
commented
May 13, 2026
Ameobea
commented
- The error messages for some auth/session-related errors were changed to be more consistent with others (https://github.com/PingThingsIO/smartgridstore/pull/4214) so that the frontend can use existing matching logic to determine that they're auth/session errors. Some tests here assert on the exact string, so they need to be updated to match.
- Currently the backend CI is pinned to read from this branch. That will have to be unpinned once this PR is merged.
* The error messages for some auth/session-related errors were changed to be more consistent with others to that the frontend can use existing matching logic to determine that they're auth/session errors. Some tests here assert on the exact string, so they need to be updated to match. * Currently the backend CI is pinned to read from this branch. That will have to be unpinned once this PR is merged.
Author
|
The SGS PR making the error changes which necessitates this has been merged: https://github.com/PingThingsIO/smartgridstore/pull/4214 So this should be good to merge now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.