[codex] add DatabaseModule root registration#133
Draft
ItayTheDar wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
DatabaseModule.for_root(...)as a global root-module entry point for SQLAlchemy setupDatabaseModule,DatabaseService, and the related injection tokens fromnest.core.databaseDatabaseServiceDatabaseModule.for_root()registrations in a single applicationDatabaseModuleand injectedDatabaseServiceWhy
The framework needed a first-class database root module instead of relying on the older provider/config pattern in generated apps. This change gives applications a single place to register database configuration, exposes a consistent injected service API for sync and async sessions, and makes the module system reject unsupported duplicate root registrations.
Impact
Applications can now configure SQLAlchemy integration from the root module and inject
DatabaseServicein feature services. The new tests cover provider registration, duplicate-root protection, lifecycle behavior, HTTP integration, async queries, and generated ORM template output.Validation
uv sync --group testuv run pytest tests/test_core/test_database/test_database_module.py tests/test_cli/test_orm_templates.py