Fix mem-mode crashing with floating point literals#14
Merged
Mittagskogel merged 4 commits intoJun 23, 2026
Conversation
…ent to nested calls to __raptor_done_truncate_mem_func* that are not callback
…est/Unit/Truncate/const.ll
MinliLiao
force-pushed
the
mem-mode-literal-param
branch
from
d6d2021 to
ac70aa7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While intrinsics work fine, mem-mode crashes when floating point literals are used as input parameters to truncated functions. An explicitly truncated function (created through
__raptor_truncate_mem_func()) requires its input parameters truncated manually through__raptor_truncate_mem_value(), which does not have a problem with floating point literals, but functions truncated due to being transitively called by explicitly truncated functions cannot work around this problem with manual truncation.This pull request fixes this problem by automatically creating a new truncated variable for literal inputs of truncated function transitively called by explicitly truncated ones, similar to how intrinsics are handled. Functions that have been explicitly truncated still has to have already truncated variables as input parameters.
This pull request also adds a manually constructed test case for this in the
test/Unit/Truncate/const.ll.