feat(smi): expose HSMP socket accumulators (accumulation_counter, soc…#73
Open
bhatturu wants to merge 2 commits into
Open
feat(smi): expose HSMP socket accumulators (accumulation_counter, soc…#73bhatturu wants to merge 2 commits into
bhatturu wants to merge 2 commits into
Conversation
…ket_gfx_busy_acc, dram_bandwidth_acc) Add socket_gfx_busy_accumulated, dram_bandwidth_accumulated, and accumulation_counter to aga_gpu_stats_t, filled from the HSMP metrics table via smi_gpu_fill_hsmp_stats_ and mapped into GPUStats proto. The HSMP table read uses ESMI-only APIs, so the fill body is guarded by ENABLE_ESMI_LIB and the gpuagent objects are compiled with -DENABLE_ESMI_LIB. amdsmi must be built with ENABLE_ESMI_LIB=ON for these symbols to resolve. APU smi init falls back to GPU init so non-APU platforms build and run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ket_gfx_busy_acc, dram_bandwidth_acc)
Add socket_gfx_busy_accumulated, dram_bandwidth_accumulated, and accumulation_counter to aga_gpu_stats_t, filled from the HSMP metrics table via smi_gpu_fill_hsmp_stats_ and mapped into GPUStats proto.
The HSMP table read uses ESMI-only APIs, so the fill body is guarded by ENABLE_ESMI_LIB and the gpuagent objects are compiled with -DENABLE_ESMI_LIB. amdsmi must be built with ENABLE_ESMI_LIB=ON for these symbols to resolve.
APU smi init falls back to GPU init so non-APU platforms build and run.
Motivation
Technical Details
Test Plan
Test Result
Submission Checklist