Skip to content

chore: make ci more robust, fix stack overflow and import problem#9948

Merged
maribethb merged 10 commits into
RaspberryPiFoundation:v13from
maribethb:fix-ci
May 29, 2026
Merged

chore: make ci more robust, fix stack overflow and import problem#9948
maribethb merged 10 commits into
RaspberryPiFoundation:v13from
maribethb:fix-ci

Conversation

@maribethb
Copy link
Copy Markdown
Contributor

@maribethb maribethb commented May 29, 2026

The basics

The details

Resolves

Fixes (hopefully) intermittent CI failures

Proposed Changes

  • fixes a stack overflow that occurred if a sound is missing (this happened because get parent's audio context always pointed to this so we just kept trying to call .play over and over again. instead we only try that if the parent audio context is not this)
  • fixes a stray import from .blockly.js instead of the more specific file
  • increases the webdriver timeout from 100 to 200 seconds because we've added more tests and maybe they're flaky because they're right on the cusp of timeout
  • added some logging and made the mocha tests fail if blockly fails to load. this is common when you introduce an accidental circular dependency and previously the tests would hang without showing an error.
  • added some try/catch/finally around closing the mocha process so that we hopefully get better errors than "did you forget to signal async completion?" from gulp
  • adds a setup Chrome action to the CI to make sure chrome is downloaded correctly... this is heavily AI-assisted code

Reason for Changes

ci is killing me

Test Coverage

tested to make sure that regular console.errors dont cause the tests to fail, but introducing a circular dependency does.

Documentation

Additional Information

@maribethb maribethb requested a review from a team as a code owner May 29, 2026 16:40
@maribethb maribethb requested review from gonfunko and lizschwab May 29, 2026 16:40
@github-actions github-actions Bot added the PR: chore General chores (dependencies, typos, etc) label May 29, 2026
@maribethb maribethb assigned lizschwab and unassigned gonfunko May 29, 2026
@github-actions github-actions Bot added PR: chore General chores (dependencies, typos, etc) and removed PR: chore General chores (dependencies, typos, etc) labels May 29, 2026
Copy link
Copy Markdown
Contributor

@lizschwab lizschwab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I like all the extra logging!

await browser.url(url);
await runHealthCheckInBrowser(browser);
} finally {
await browser.deleteSession();
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@maribethb maribethb enabled auto-merge (squash) May 29, 2026 18:52
@lizschwab lizschwab self-requested a review May 29, 2026 18:52
@maribethb maribethb merged commit 7682eea into RaspberryPiFoundation:v13 May 29, 2026
5 checks passed
@maribethb maribethb deleted the fix-ci branch May 29, 2026 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: chore General chores (dependencies, typos, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants