chore: make ci more robust, fix stack overflow and import problem#9948
Merged
Conversation
lizschwab
reviewed
May 29, 2026
Contributor
lizschwab
left a comment
There was a problem hiding this comment.
Looks good. I like all the extra logging!
| await browser.url(url); | ||
| await runHealthCheckInBrowser(browser); | ||
| } finally { | ||
| await browser.deleteSession(); |
lizschwab
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes (hopefully) intermittent CI failures
Proposed Changes
thisso we just kept trying to call.playover and over again. instead we only try that if the parent audio context is notthis).blockly.jsinstead of the more specific fileReason for Changes
ci is killing me
Test Coverage
tested to make sure that regular console.errors dont cause the tests to fail, but introducing a circular dependency does.
Documentation
Additional Information