Skip to content

Release Reaper Web-Video Downloader v1.0#1734

Open
CalaFlan wants to merge 1 commit into
ReaTeam:masterfrom
CalaFlan:reapack.com_upload-1780605139025
Open

Release Reaper Web-Video Downloader v1.0#1734
CalaFlan wants to merge 1 commit into
ReaTeam:masterfrom
CalaFlan:reapack.com_upload-1780605139025

Conversation

@CalaFlan

@CalaFlan CalaFlan commented Jun 4, 2026

Copy link
Copy Markdown

First Commit

@cfillion

cfillion commented Jun 5, 2026

Copy link
Copy Markdown
Member

This uses os.execute/io.popen in a way that is both vulnerable to command injection and can easily freeze REAPER for >1 secs, plus requires externally-sourced files to function. As per the guidelines this cannot be released here in the current form.

(Unrelated to releasing, just an observation: by the time importVideo is invoked there is no guarantee a newer file hasn't been created after yt-dlp's, leading to get_last_file_name returning an incorrect value, or yt-dlp just didn't create any file leading to the same)

@CalaFlan

CalaFlan commented Jun 5, 2026

Copy link
Copy Markdown
Author

Yeah that’s all fair enough, I'll admit its a pretty scuff setup atm. I'm going to take a look and see if I rejig this using python in a way that isn't so dodgy. I'll submit something if I can get it working, either way thanks for taking the time to review this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants