chore: update dependencies#470
Conversation
|
See DataBiosphere/dsub#328 for the associated issue blocking a dependency bump. |
|
What specifically is this being used for the heuristics? Do we need to use pyparsing; is there a simpler way to parse? |
|
Tony mentioned boolean-parse, but it is also an unmaintained library with what seems to be no users. I'm much more comfortable just inlining the parsing logic we need because of that. At the moment, we use a handwritten parser, but I notably made a few mistakes in said handwritten parser, so I would like to avoid using that in the future (one can also avoid that by adding a bucket of tests to said handwritten parser, but that seems suboptimal compared to having a nice way to declare the parser in the first place). Using |
|
Oh, I can just bump down dsub. |
i was Very wrong about that
get_original_bases does _not_ have the same signature as its internal reflection counterpart!
pandas requires precisely one of (argument-based list specification) or (axis specification)
Trying to resolve mac errors
We could also use an object representation, which would solve the parsing issue with the cost of making it a pain for users to specify heuristics. |
There was a problem hiding this comment.
This pull request combines bumping dependencies and the typing code. It would be faster to review if we decouple this.
I also want to eliminate all install errors before the ISMB tutorial, so I will make a separate PR just for that.
I noticed that the tests are also failing.
| "Topic :: Scientific/Engineering :: Bio-Informatics", | ||
| ] | ||
| requires-python = ">=3.11" | ||
| requires-python = ">=3.13" |
There was a problem hiding this comment.
What do we gain and lose by bumping the minimal Python version we support? The typing related changes here don't look significant enough to drop support for older Python versions.
I wanted to try out pyparsing for #431, but ran into some outdated dependency issues. We also:
get_params_genericand move validation logic into it.