Fix multi-value attribute cells rendering with page-ref brackets#329
Open
salmonumbrella wants to merge 1 commit into
Open
Fix multi-value attribute cells rendering with page-ref brackets#329salmonumbrella wants to merge 1 commit into
salmonumbrella wants to merge 1 commit into
Conversation
extractTag only unwraps a single whole-string tag, so multi-value attributes kept their [[ ]] while single values did not. Add an opt-in stripRefs flag to toCellValue, set only at the results-table display site, leaving raw-value callers (filters, kanban, in-place edits) unchanged.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In Query Builder result tables a single-value attribute renders unwrapped (e.g.
[[A]]→A), but a multi-value attribute keeps its brackets (e.g.[[A]], [[B]]→[[A]], [[B]]). The two are inconsistent.Cause
toCellValuecleans cell text withextractTag, which only unwraps a single, whole-string tag. For a multi-value string its guard sees the inner]]before the next[[, bails out, and returns the value unchanged — so the brackets stay.Fix
Add an opt-in
stripRefsflag totoCellValuethat strips the page-ref delimiters from every remaining ref, and pass it from the results-table display site (ResultRow'scell()).It is off by default, so callers that rely on the raw value are unchanged:
filterData)referencesin-place edit inpredefinedSelections(blockText.replace(toCellValue(...), value))So this only changes how cells are displayed — not filtering, sorting, or editing.
Before / After (display)
[[A]][[A]], [[B]][[A]], [[B]]