Improve & simplify redist auto-update automation#608
Merged
Conversation
Simplify/DRY: - Add .github/variants.json as the single source of truth for all 10 variants; Update/Matrix/Verify build their matrices from it via jq + fromJson (removes the determine-variants job, the vars case block, the 68-line Matrix include, and the duplicated variant->dir case in Verify). - Use fixed PR branches redist-update/<variant> with delete-branch:true; drop timestamped branches and the broken existing-PR-by-title check. - Drop dead .NET 6.0.x (tool is net9, DepotDownloader net8). - Replace tj-actions/changed-files with native git diff. Robustness: - Remove continue-on-error masking; failures now surface (fail-fast:false keeps other variants running). Validate the manifest id and .commit file; capture redist-tool output; set -euo pipefail in the nuget-pack action. - notify-failure job opens/updates a tracking issue on scheduled failures. Security: - Pin all third-party actions to commit SHAs; pass Steam/NuGet secrets via env. Verify depth: - Add SHA-256 verification against manifest.sha256.json and a newer-build gate keyed on the Steam BuildId (monotonic across upstream rollbacks); a NuGet version dip is a warning, not a block. Docs: add ARCHITECTURE.md + architecture.svg (pipeline diagram), link from README, allowlist them in .gitignore, and ignore stray redist/**/*.nupkg. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Both Steam tools can exit non-zero even on success. Don't trust their exit codes: the 19-digit manifest validation (DepotDownloader) and the redist tool's own file check (SteamCMD) remain the real gates, so genuine failures still turn the run red without false-failing on the tools' cosmetic exit codes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify/DRY:
Robustness:
Security:
Verify depth:
Docs: add ARCHITECTURE.md + architecture.svg (pipeline diagram), link from README, allowlist them in .gitignore, and ignore stray redist/**/*.nupkg.