Add skills announce usage config#1
Draft
mrubens wants to merge 1 commit into
Draft
Conversation
d96e50e to
83ccb24
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new Codex config flag:
When unset, the effective value defaults to
true, preserving current behavior. When set tofalse, Codex still injects the automatic skills instructions block but omits only this guidance line:The setting is included in the effective runtime config, preserved through config locking/replay, and threaded into both absolute-path and alias-based skills rendering.
Request
Enhancement request: add a config escape hatch for skill-use announcement guidance while keeping automatic skills instructions and explicit skill injection behavior unchanged.
No public issue link was provided for this draft PR.
Testing
just write-config-schemajust fmtcargo test -p codex-core-skillscargo test -p codex-coreOne unrelated timeout occurred in
agent::control::tests::resume_thread_subagent_restores_stored_nickname_and_role.cargo test -p codex-core agent::control::tests::resume_thread_subagent_restores_stored_nickname_and_rolejust fix -p codex-corejust fix -p codex-core-skillsRename follow-up:
just write-config-schemajust fmtcargo test -p codex-core skill_announce_usagecargo test -p codex-core-skills render_body