EIFRCN-2131: DCG PUT API- Align Mandatory Fields#1834
Conversation
| | `uuid`| `string` | - | Document UUID - field present in compliance document/Government doc unique id.| MX, PL | FR | | ||
| | `grossAmount` | `number` | - | Sum of amounts before discounts and taxes. | Yes | - | | ||
| | `currency` | `string` | `enum`: [`MXN`, `EUR`, `PLN`]| Currency used to express amounts (According to the ISO 4217 codes).| Yes | - | | ||
| | `exchangeRate` | `number` | - | Exchange Rate according to currency used. | FR, PL | MX | |
There was a problem hiding this comment.
This is currency-dependent logic disguised as country-dependent, which is wrong: if an MX partner sends a transaction in USD, exchangeRate would also be required. Please check this point. Its in Discrepancy with Swagger May be.
There was a problem hiding this comment.
exchange rate was hence to be considered optional as it is case to case basis for a given country.
| | `buyer`| `object` | [Buyer schema](#buyer-schema)| Details of the buyer.| - | Yes | | ||
| | `code` | `string` | - | Prefix of receipt, an alphanumeric field that can refer to a physical place (POS, branch, factory, warehouse, office, etc.) or any other criteria (like business, line of product, etc.) | - | Yes | | ||
| | `documentPostalCode`| `string` | - | Postal code of place of receipt issue.| - | Yes | | ||
| | `paymentType` | `string` | `enum`: [`Cash`, `Credit Card`, `Digital Wallet`] | Means of payment.| - | Yes | |
There was a problem hiding this comment.
Old markdown had: enum: ["01, 02, 03"], description: "01 (Cash), 02 (Cheque), 03 (Bank Transfer/Digital Wallet)"
New markdown has: enum: [Cash, Credit Card, Digital Wallet]
Two problems:
Cheque was replaced by Credit Card — these are different payment methods, not a rename
Bank Transfer/Digital Wallet was split and only Digital Wallet remains
Is this expected?
| | `issueDateTime` | `string` | YYYY-MM-DDTHH:mm:ssZ | Date and time when the document was created in the local timezone where it was issued.| Yes | - | | ||
| | `uuid`| `string` | - | Document UUID - field present in compliance document/Government doc unique id.| MX, PL | FR | | ||
| | `grossAmount` | `number` | - | Sum of amounts before discounts and taxes. | Yes | - | | ||
| | `currency` | `string` | `enum`: [`MXN`, `EUR`, `PLN`]| Currency used to express amounts (According to the ISO 4217 codes).| Yes | - | |
There was a problem hiding this comment.
Removing INR, USD, and the open-ended ... could break partners in other countries if they ever onboard. This should be confirmed as intentional.
relevant with this comment
tarunkhatri20
left a comment
tarunkhatri20
left a comment
There was a problem hiding this comment.
Keep in draft until release of FR pull functionality.
| | `uuid`| `string` | - | Document UUID - field present in compliance document/Government doc unique id.| MX, PL | FR | | ||
| | `grossAmount` | `number` | - | Sum of amounts before discounts and taxes. | Yes | - | | ||
| | `currency` | `string` | `enum`: [`MXN`, `EUR`, `PLN`]| Currency used to express amounts (According to the ISO 4217 codes).| Yes | - | | ||
| | `exchangeRate` | `number` | - | Exchange Rate according to currency used. | FR, PL | MX | |
There was a problem hiding this comment.
exchange rate was hence to be considered optional as it is case to case basis for a given country.
3 participants
EIFRCN-2131