[SYNPY-1863] deepcopy annotations in SubmissionStatus._set_last_persistent_instance

[jaymedina]

Problem:

When calling <SubmissionStatusObject>.submission_annotations.update() on a SubmissionStatus object, the dataclass does not register a change and throws a warning that the object has not been modified, resulting in the annotations never being correctly posted to Synapse.

Solution:

Implement the pattern already established in the repository (example: Project OOP model) by performing deepcopy on mutable objects, such as dicts, while performing replace (shallow copy) on immutable objects where it doesn't matter if the 2 instances (last and current) share references.

This should prevent issues with the client not detecting changes to the dataclass instance when a user performs in-place mutations instead of re-assigning the attribute, i.e:

# doing this
my_status.annotations.update({"status": "PASSED"})

# instead of this
my_status.annotations = {"status": "PASSED"}

Testing:

✅ Can no longer reproduce user-error

New tests that cover in-place mutation scenarios are passing:

[BryanFauble]

Can we get away with a unit test only for this change to verify the has_changed and this _set_last_persistent_instance logic?

[Copilot]

Pull request overview

Fixes change-tracking on SubmissionStatus so in-place mutations to mutable annotation fields (e.g., dict.update()) are detected and persisted, avoiding “object has not been modified” warnings and missed updates.

Changes:

• Deep-copies annotations and submission_annotations when stashing _last_persistent_instance to prevent shared references.
• Adds async integration tests covering in-place mutation scenarios for both annotation containers.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
synapseclient/models/submission_status.py	Adjusts last-persistent snapshotting to avoid shared references for mutable annotation fields.
tests/integration/synapseclient/models/async/test_submission_status_async.py	Adds integration tests asserting in-place dict mutations are detected and stored.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[andrewelamb]

LGTM!