Skip to content

Fix incorrect typing on create_file_based_metadata_task#1415

Merged
andrewelamb merged 2 commits into
developfrom
fix_incorrect_typing
Jun 25, 2026
Merged

Fix incorrect typing on create_file_based_metadata_task#1415
andrewelamb merged 2 commits into
developfrom
fix_incorrect_typing

Conversation

@andrewelamb

@andrewelamb andrewelamb commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Problem:

The type hint create_file_based_metadata_task returned CurationTask is str when it should be int

Solution:

Type hint is corrected

@andrewelamb andrewelamb requested a review from a team as a code owner June 25, 2026 15:08
linglp
linglp approved these changes Jun 25, 2026
View reviewed changes

@linglp linglp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix.

@andrewelamb andrewelamb merged commit e1aaed9 into develop Jun 25, 2026
17 of 23 checks passed
@andrewelamb andrewelamb deleted the fix_incorrect_typing branch June 25, 2026 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@linglp linglp linglp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@andrewelamb @linglp