Skip to content

chore: migrate iframe to standalone repo#871

Merged
salmanfarisvp merged 2 commits into
masterfrom
chore/remove-iframe
Jun 29, 2026
Merged

chore: migrate iframe to standalone repo#871
salmanfarisvp merged 2 commits into
masterfrom
chore/remove-iframe

Conversation

@nicomiguelino

@nicomiguelino nicomiguelino commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

User description

Removes source files from edge-apps/iframe and redirects to Screenly/iframe-app. Closes #829.


PR Type

Other, Documentation


Description

  • Migrates iframe app to standalone repository

  • Removes bundled iframe app implementation

  • Redirects documentation to new repository


Diagram Walkthrough

flowchart LR
  A["Playground iframe app"] 
  B["Source files removed"]
  C["Screenly/iframe-app repository"]
  D["README links updated"]
  A -- "migrated out" --> C
  A -- "cleanup" --> B
  D -- "points users to" --> C
Loading

File Walkthrough

Relevant files
Miscellaneous
3 files
main.js
Remove iframe runtime JavaScript implementation                   
+0/-23   
style.css
Remove iframe app styling definitions                                       
+0/-21   
index.html
Remove iframe app HTML entrypoint                                               
+0/-19   
Documentation
2 files
README.md
Redirect iframe app listing externally                                     
+1/-1     
README.md
Replace iframe guide with repository notice                           
+2/-60   
Configuration changes
3 files
.ignore
Remove iframe QC ignore configuration                                       
+0/-1     
screenly.yml
Remove iframe production manifest                                               
+0/-16   
screenly_qc.yml
Remove iframe QC manifest                                                               
+0/-16   

- remove source files from edge-apps/iframe
- redirect README to Screenly/iframe-app
- update root README entry
@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown

PR Reviewer Guide 🔍

(Review updated until commit f5da553)

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis ✅

829 - PR Code Verified

Compliant requirements:

  • Migrate edge-apps/iframe from the Playground monorepo to Screenly/iframe-app.
  • Redirect documentation to the standalone repository.

Requires further human verification:

  • Confirm the standalone Screenly/iframe-app repository contains the migrated source and documentation.
⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected

@github-actions

Copy link
Copy Markdown

PR Code Suggestions ✨

No code suggestions found for the PR.

@nicomiguelino nicomiguelino marked this pull request as ready for review June 27, 2026 05:06
@github-actions

Copy link
Copy Markdown

Persistent review updated to latest commit f5da553

@github-actions

Copy link
Copy Markdown

PR Code Suggestions ✨

No code suggestions found for the PR.

514sid
514sid previously approved these changes Jun 29, 2026
514sid
514sid previously approved these changes Jun 29, 2026
@salmanfarisvp salmanfarisvp self-requested a review June 29, 2026 09:19
salmanfarisvp
salmanfarisvp previously approved these changes Jun 29, 2026
@514sid 514sid dismissed stale reviews from salmanfarisvp and themself via d737f01 June 29, 2026 09:29
@514sid 514sid force-pushed the chore/remove-iframe branch from b7ec972 to d737f01 Compare June 29, 2026 09:29
@salmanfarisvp salmanfarisvp merged commit 581e682 into master Jun 29, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: migrate edge-apps/iframe to standalone repo (Screenly/iframe-app)

3 participants