Skip to content

ci: avoid redundant dashboard builds#74

Merged
ScriptedAlchemy merged 1 commit into
masterfrom
codex/stack-06-ci-speed
Jun 21, 2026
Merged

ci: avoid redundant dashboard builds#74
ScriptedAlchemy merged 1 commit into
masterfrom
codex/stack-06-ci-speed

Conversation

@ScriptedAlchemy

Copy link
Copy Markdown
Owner

Summary

  • remove duplicate dashboard Node setup/build steps from Rust test, Clippy, and Hermes integration jobs
  • keep dashboard asset build, dist verification, unit tests, integration tests, and smoke tests in the dedicated Dashboard job
  • disable debug info for CI dev/test profiles to reduce compile/link work, especially on Windows

Validation

  • python3 YAML parse for .github/workflows/ci.yml
  • git diff --check

@changeset-bot

changeset-bot Bot commented Jun 21, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: dbc9df2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

- name: Run tests
run: cargo test --workspace

P2 Badge Restore pinned Node setup before Cargo builds

In these Rust jobs, a fresh checkout still reaches build.rs when cargo test/cargo clippy/cargo build starts; the dashboard JS/CSS dist files are gitignored, and build.rs detects them as missing then runs npm ci and npm run build (build.rs:263-273, build.rs:125-134). Because this change removed actions/setup-node from those jobs without sharing the Dashboard job’s generated dist artifacts across job workspaces, they now rebuild the dashboard using whatever npm happens to be on the runner PATH, losing the pinned Node 22 setup/cache and making the CI path slower and less deterministic rather than avoiding redundant builds.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ScriptedAlchemy ScriptedAlchemy changed the base branch from codex/stack-05-compression-context-hints to master June 21, 2026 07:10
@ScriptedAlchemy ScriptedAlchemy merged commit 161c5d9 into master Jun 21, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant