Use probeinterface and neo source when using spikeinterface source#4615
Open
chrishalcrow wants to merge 1 commit into
Open
Use probeinterface and neo source when using spikeinterface source#4615chrishalcrow wants to merge 1 commit into
chrishalcrow wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #4593
Currently, when you install SpikeInterface from source, the dependencies are release versions of ProbeInterface and Python-Neo.
pipobeys this.uvlooks at the other dependency groups and decides that the source versions should be used. Hence we have a mismatch in behavior betweenuvandpip.Additionally, if you are using SpikeInterface from source, you almost certainly want ProbeInterface and Neo from source. This PR makes this the default.
Note: now when you release, you only need to change two lines in the pyproject.toml, not six!
Note: the development docs still make sense after this change.