Move CodeGeneratorRequestWriter to ToolBase#943
Closed
alexander-yevsyukov wants to merge 5 commits into
Closed
Conversation
The class is protoc-plugin tooling, not runtime API: its only consumers are the protoc-plugin entry points of the Compiler and ProtoTap. It moves to the `tool-base` module of ToolBase as `io.spine.tools.code.proto.CodeGeneratorRequestWriter`. `CodeGeneratorRequestParsingSpec` and `CodeGeneratorRequestsJavaSpec` stay because they test the `io.spine.type` parsing API, which remains in `base`. See #938
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #943 +/- ##
==========================================
- Coverage 94.06% 94.04% -0.03%
==========================================
Files 193 192 -1
Lines 4164 4149 -15
Branches 339 339
==========================================
- Hits 3917 3902 -15
Misses 147 147
Partials 100 100 🚀 New features to boost your workflow:
|
Contributor
Author
|
Merged into #944, which now combines both removals (this branch was merged into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #938.
io.spine.code.proto.CodeGeneratorRequestWriteris protoc-plugin tooling, not runtime API: its only consumers are the protoc-plugin entry points of the Compiler and ProtoTap. It moves to thetool-basemodule of ToolBase asio.spine.tools.code.proto.CodeGeneratorRequestWritervia SpineEventEngine/tool-base#181.Changes
CodeGeneratorRequestWriterand its spec frombase.2.0.0-SNAPSHOT.410(next multiple of 10 — removing public API is a breaking change).Notes
CodeGeneratorRequestParsingSpecandCodeGeneratorRequestsJavaSpecstay: they test theio.spine.typeparsing API, which remains inbase, and the Java spec still uses theconstructRequesthelper declared in the Kotlin parsing spec.io.spine.code.protostays inbase(KnownTypesloads descriptor sets through it at application startup).CodeGeneratorRequestWriterfrom Base; fix plugins to work with Gradle cache; fixArtifactMetaPluginworking directory tool-base#181 first, then this PR; consumers then migrate by switching the import.https://claude.ai/code/session_01QkiJSc86Y7ocs1PeZMxJhX
Generated by Claude Code