This repository was archived by the owner on Jun 4, 2026. It is now read-only.
Bump Protobuf and other dependencies#198
Merged
Merged
Conversation
Also: * Force dependencies.
McJava carries the plugin in itself in the fat JAR. We put the newer plugin first so that it's compatible with the newer Kotlin.
yevhenii-nadtochii
approved these changes
May 19, 2025
yevhenii-nadtochii
left a comment
yevhenii-nadtochii
left a comment
Contributor
There was a problem hiding this comment.
LGTM with a question.
Comment on lines
+138
to
+140
| // See if the file is fully written by expecting the final closing brace. | ||
| val lines = buildGradleFile.readLines() | ||
| if (!lines.any { it.startsWith("}")}) { |
Contributor
There was a problem hiding this comment.
I don't really understand how checking for } says that the file write is complete.
- Maybe it must be the last line to contain
}? In case, we are aware about the content of this build file. - Maybe just to wait a fixed time period after the file is discovered? In case, we are not aware about the potential content.
Contributor
Author
There was a problem hiding this comment.
Sometimes we leave two empty lines at the end by mistake. This check is a bit more flexible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates to new major version of Protobuf (v4.31.0), newest Kotlin, Gradle, and bumps local dependencies that are already compatible with these external dependencies.
Other notable changes
BomsPlugin.