Skip to content

add option to keep v prefix in tag#149

Open
monotek wants to merge 1 commit into
mainfrom
add-keep-v-prefix-option
Open

add option to keep v prefix in tag#149
monotek wants to merge 1 commit into
mainfrom
add-keep-v-prefix-option

Conversation

@monotek
Copy link
Copy Markdown
Member

@monotek monotek commented Jun 8, 2026

Type of Change

  • Bugfix
  • Enhancement / new feature
  • Refactoring
  • Documentation

Description

  • add option to keep v prefix in tag

Checklist

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Review the Contributing Guideline and sign CLA
  • Reference relevant issue(s) and close them after merging

Signed-off-by: André Bauer <andre.bauer@staffbase.com>
@monotek monotek marked this pull request as ready for review June 8, 2026 11:36
@monotek monotek requested review from a team as code owners June 8, 2026 11:36
@timdittler
Copy link
Copy Markdown
Contributor

why is this needed?

@monotek
Copy link
Copy Markdown
Member Author

monotek commented Jun 8, 2026

why is this needed?

I have a repo where the tags use the "v" prefix.

@timdittler
Copy link
Copy Markdown
Contributor

Why not adhere to the global standard and drop the v?

@monotek
Copy link
Copy Markdown
Member Author

monotek commented Jun 8, 2026

Maybe someone wants to use this on a non staffbase repo ;-)
It's also optional.

@timdittler
Copy link
Copy Markdown
Contributor

@0x46616c6b what do you think? I lean towards not merging this, as I cannot see a use-case and don't want to maintain it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants