ST6RI-941 NPE when evaluating derived properties on feature chains#772
Draft
AxelRICHARD wants to merge 1 commit into
Draft
ST6RI-941 NPE when evaluating derived properties on feature chains#772AxelRICHARD wants to merge 1 commit into
AxelRICHARD wants to merge 1 commit into
Conversation
Signed-off-by: Axel RICHARD <axel.richard@obeo.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Evaluating some SysML derived properties can fail with a NullPointerException when the model contains an unresolved feature chain.
The problem occurs in
TypeUtil.getOwnedParametersOf(Type type). When the provided type is aFeature, the method first resolves its basic feature throughFeatureUtil.getBasicFeatureOf(...). For a chained feature whose target has not been resolved yet, this call may return null. The method then unreferences that null value by callingtype.getOwnedFeature().A concrete failing scenario is an
AssignmentActionUsagecontaining an unresolvedFeatureChaining. When its derived valueExpression property is evaluated, the computation asksTypeUtilfor owned parameters and triggers the NPE.
Expected behavior: unresolved feature chains should be treated as having no owned parameters at this stage, so derived property evaluation should return null or an empty result instead
of crashing.
This issue prevents robust handling of partially linked SysML models and can break workflows that evaluate derived properties before all feature chain references are resolved.