Rafactor/chore#73
Open
kapitulin24 wants to merge 5 commits into
Open
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
github-actions
Bot
added
devops
ui-kit
This was
linked to
issues
Jun 9, 2026
soorq
reviewed
Jun 9, 2026
|
|
||
| const TeamContent = dynamic(() => import('./TeamContent').then((mod) => mod.TeamContent), { | ||
| ssr: false, | ||
| loading: () => <TeamFallback />, |
Collaborator
There was a problem hiding this comment.
Не поможет, переходи в Suspense, лучше так к слову не делать, и не удобно собирать всю страницу компонентами лоадеров, тебе легче сделать под маленькие компоненты и из них собирать общий лоадер, а так если глобально, вдруг у тебя пришли данные н-ые, но у тебя будет лоадер всей страницы, компонента, а так монолитно разбираешь и все
| } | ||
| }; | ||
|
|
||
| if (!projects.data) { |
Collaborator
There was a problem hiding this comment.
Лучше наверх выносить эту историю, чтоб начать сразу из отрицания
|
|
||
| export function ProjectActions({ project, teamId, ...props }: ProjectActionsProps) { | ||
| const { isMobile } = useSidebar(); | ||
| const [dropdownOpen, setDropdownOpen] = useState(false); |
Collaborator
There was a problem hiding this comment.
Батчинг, приветик =)
Тут легче тебе заложить в 1 стейт, и жить с ним
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Что сделано
/profile/*на/user/*с обновлением маршрутов, редиректов и навигации.teamsиinvitations) с переносом связанной логики.open/onOpenChange, корректное закрытие и reset состояния).Зачем
Проверка
/user.