Docs site at reporter.tharga.net + PackageIconUrl migration#8
Merged
Conversation
Mirrors the Tharga.Console pattern (PR #35): - PackageIconUrl in Tharga.Reporter.csproj now points at https://thargelion.net/assets/component-reporter.png (was a WordPress upload URL on thargelion.se). - DocFX site under docs/ with index, 4 articles (getting-started, templates, elements, data-and-rendering), and API metadata generated from Tharga.Reporter.csproj. - Absolute-URL logo via thargelion.net/assets, with the templates/thg/layout/_master.tmpl overlay that moves _rel into the fallback path only — fixes the ../https://... corruption on DocFX 2.78.x sub-pages. - CNAME → reporter.tharga.net. - build.yml gets pages: write + id-token: write permissions and two new jobs (docs, docs-deploy) chained after release. - README links to reporter.tharga.net and includes a short description matching the docs landing page. - .gitignore excludes docs/_site and docs/api (generated).
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Released as v2.3.6 — https://github.com/Tharga/Reporter/releases/tag/2.3.6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bundles two requests from the meta-repo, following the Tharga.Console pattern (PR #35):
https://thargelion.net/assets/component-reporter.png(was a WordPress upload URL onthargelion.se).reporter.tharga.net— landing page + 4 articles (getting-started, templates, elements, data-and-rendering) + API reference generated fromTharga.Reporter.csproj.templates/thg/layout/_master.tmploverlay that moves{{_rel}}into the fallback path only (DocFX 2.78.x bug — see Console PR #35).docs+docs-deployjobs added tobuild.yml, chained afterrelease, gated on master push.pages: write+id-token: writepermissions added.reporter.tharga.netand includes a short description.Required setup before merging
reporter.tharga.net→tharga.github.ioconfirmedcomponent-reporter.pngexists athttps://thargelion.net/assets/(verifiedHTTP 200locally)Test plan
curl -I https://thargelion.net/assets/component-reporter.png→200 OKdocfx docs/docfx.json→ 0 errors, 49 API files, 6 conceptual filessrc="https://thargelion.net/...", no../https://...corruption)dotnet build -c Release→ 0 errors, 15 warnings (under threshold)dotnet test -c Release→ 6 passed, 44 skipped (legacy), 0 failedreporter.tharga.net/articles/loads with correct logo