fix(test): replace bare delay with poll in AutoStart_starts_timer_immediately#42
Merged
Merged
Conversation
A bare Task.Delay(50) was too short for busy Linux CI runners — the timer's async startup hadn't transitioned out of Stopped within 50 ms. Replace with a 2-second polling loop. Locally the loop exits within one iteration; on CI it tolerates scheduling jitter. Caught on the first master push after PR #41 merged.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Released as v1.15.25 — https://github.com/Tharga/Toolkit/releases/tag/1.15.25 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AutoStart_starts_timer_immediatelyfailed on the master build after PR #41 —Task.Delay(50)was not enough to let the timer transition out ofStoppedon a busy Linux runner.Replaces the bare delay with a 2-second polling loop. Locally exits in one iteration; on CI it tolerates scheduling jitter.
Test plan