Skip to content

fix(find): improve readability and visibility of highlighted matches in dark mode#173

Merged
ThisIs-Developer merged 1 commit into
mainfrom
fix/dark-mode-find-contrast
Jun 11, 2026
Merged

fix(find): improve readability and visibility of highlighted matches in dark mode#173
ThisIs-Developer merged 1 commit into
mainfrom
fix/dark-mode-find-contrast

Conversation

@ThisIs-Developer

Copy link
Copy Markdown
Owner

Description

This PR addresses visibility and contrast issues with the Find & Replace highlighted matches in Dark Mode.

Since the editor is a standard <textarea>, character-level text coloring cannot be customized inside it (it uses the main text color, which is a light gray #c9d1d9 in dark mode). Overlaying bright yellow/orange highlights made text completely unreadable.

Solution

  1. Legible Backgrounds in Dark Mode: Adjusted --fr-match-active from a bright solid yellow (#f1e05a) to a solid dark orange/gold (#ad6200). This ensures the white/light-gray text remains highly readable.
  2. Text Color Overrides: Introduced new --fr-match-text-color and --fr-match-active-text-color variables to enforce high-contrast text rendering on highlights in the HTML preview pane.
  3. Active Match Outline: Added a 1px outline using the theme's var(--accent-color) to active matches in both the editor and preview. This enables active matches to stand out instantly without relying on overly bright backgrounds.

Files Modified

  • styles.css — Core CSS updates.
  • desktop-app/resources/styles.css — Synchronized desktop assets via build pipeline.

Verification Details

  • Light Mode: Retains soft yellow (#ffdf5d) and orange (#ff9b30) highlights with a blue outline for active match.
  • Dark Mode: All matches render as translucent gold; the active match displays as dark orange/gold with white text and a light blue outline (#58a6ff). Text is fully legible.

@vercel

vercel Bot commented Jun 11, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
markdown-viwer Ready Ready Preview, Comment Jun 11, 2026 5:00am

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@ThisIs-Developer ThisIs-Developer merged commit f115076 into main Jun 11, 2026
6 checks passed
@ThisIs-Developer ThisIs-Developer deleted the fix/dark-mode-find-contrast branch June 11, 2026 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant